valkyr/boilerplate
Template
1
0
Fork 0
Code Issues Wiki Activity

feat: add currency assertion to account creation

Browse Source
This commit is contained in:
kodemon
2025-12-06 05:01:01 +01:00
parent be9b8e9e55
commit ce4d5ba013
8 changed files with 77 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
modules/payment/repositories/account.ts
View File

@@ -1,9 +1,7 @@
import { db } from "@platform/database";
import { BadRequestError, ConflictError } from "@platform/relay";
import { BadRequestError } from "@platform/relay";
import { type Account, type AccountInsert, AccountInsertSchema, AccountSchema } from "../schemas/account.ts";
import { getLedgerById } from "./ledger.ts";
import { getWalletById } from "./wallet.ts";
/**
* Create a new account.
@@ -15,23 +13,6 @@ export async function createAccount(values: AccountInsert): Promise<string> {
.begin(async () => {
const _id = crypto.randomUUID();
// const wallet = await getWalletById(values.walletId);
// if (wallet === undefined) {
// throw new ConflictError(`Wallet '${values.walletId}' does not exist`);
// }
// const ledger = await getLedgerById(wallet.ledgerId);
// if (ledger === undefined) {
// // TODO: RAISE ALARMS, THIS SHOULD NEVER OCCUR
// throw new ConflictError(`Wallet ledger '${wallet.ledgerId}' does not exist`);
// }
// if (ledger.currencies.includes(values.currency) === false) {
// throw new BadRequestError(
// `Ledger does not support '${values.currency}' currency, supported currencies '${ledger.currencies.join(", ")}'`,
// );
// }
// Assert wallet exists
await db.sql`
ASSERT EXISTS (
@@ -58,11 +39,16 @@ export async function createAccount(values: AccountInsert): Promise<string> {
FROM payment.wallet w
JOIN payment.ledger l ON l._id = w."ledgerId"
WHERE w._id = ${db.text(values.walletId)}
AND ${db.text(values.currency)} = ANY(l.currencies)
AND ${db.text(values.currency)} IN (
SELECT
currency
FROM
UNNEST(l.currencies) AS x(currency)
)
), 'unsupported_currency';
`;
await db.sql`INSERT INTO payment.wallet RECORDS ${db.transit({ _id, ...AccountInsertSchema.parse(values) })}`;
await db.sql`INSERT INTO payment.account RECORDS ${db.transit({ _id, ...AccountInsertSchema.parse(values) })}`;
return _id;
})
@@ -72,13 +58,13 @@ export async function createAccount(values: AccountInsert): Promise<string> {
}
switch (error.message) {
case "missing_wallet": {
throw new ConflictError("Account wallet does not exist");
throw new BadRequestError("Account wallet does not exist");
}
case "missing_ledger": {
throw new ConflictError("Account ledger does not exist");
throw new BadRequestError("Account ledger does not exist");
}
case "unsupported_currency": {
throw new ConflictError("Invalid account currency");
throw new BadRequestError("Invalid account currency");
}
}
throw error;

32
modules/payment/repositories/ledger.ts
View File

@@ -1,7 +1,7 @@
import { db } from "@platform/database";
import { ConflictError } from "@platform/relay";
import { BadRequestError } from "@platform/relay";
import { type Ledger, type LedgerInsert, LedgerInsertSchema, LedgerSchema } from "../schemas/ledger.ts";
import { type Ledger, type LedgerInsert, LedgerSchema } from "../schemas/ledger.ts";
/**
* Create a new ledger.
@@ -13,28 +13,30 @@ export async function createLedger(values: LedgerInsert): Promise<string> {
.begin(async () => {
const _id = crypto.randomUUID();
await db.sql`ASSERT EXISTS (SELECT 1 FROM payment.beneficiary WHERE _id = ${db.text(values.beneficiaryId)}), 'missing_beneficiary'`;
await db.sql`INSERT INTO payment.ledger RECORDS ${db.transit({ _id, ...LedgerInsertSchema.parse(values) })}`;
await db.sql`
INSERT INTO payment.ledger (
_id,
"beneficiaryId",
currencies,
label
) VALUES (
${db.text(_id)},
${db.text(values.beneficiaryId)},
${db.array(values.currencies)},
${values.label ? db.text(values.label) : null}
)
`;
return _id;
})
.catch((error) => {
if (error instanceof Error && error.message === "missing_beneficiary") {
throw new ConflictError(`Benficiary '${values.beneficiaryId}' does not exist`);
throw new BadRequestError(`Benficiary '${values.beneficiaryId}' does not exist`);
}
throw error;
});
}
export async function getLedgersByBeneficiary(beneficiaryId: string): Promise<Ledger[]> {
console.log(
await db.sql`
SELECT
*, _system_from as "createdAt"
FROM
payment.ledger
WHERE
"beneficiaryId" = ${beneficiaryId}
`,
);
return db.schema(LedgerSchema).many`
SELECT
*, _system_from as "createdAt"
@@ -48,7 +50,7 @@ export async function getLedgersByBeneficiary(beneficiaryId: string): Promise<Le
export async function getLedgerById(id: string): Promise<Ledger | undefined> {
return db.schema(LedgerSchema).one`
SELECT
*, _system_from as "createdAt"
*, _system_from as "created_at"
FROM
payment.ledger
WHERE

2
modules/payment/schemas/ledger.ts
View File

@@ -14,7 +14,7 @@ import { CurrencySchema } from "./currency.ts";
export const LedgerSchema = z.strictObject({
_id: z.uuid().describe("Primary identifier of the ledger"),
beneficiaryId: z.uuid().describe("Identifier of the beneficiary this ledger belongs to"),
label: z.string().optional().describe("Human-readable identifier for the ledger"),
label: z.string().nullable().optional().describe("Human-readable identifier for the ledger"),
currencies: z.array(CurrencySchema).describe("Currency this ledger trades in"),
createdAt: z.coerce.date().describe("Timestamp the ledger was created"),
});